manifest: support empty config for artifacts (PROJQUAY-6658) #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2647 +/- ##
==========================================
+ Coverage 70.69% 70.71% +0.01%
==========================================
Files 435 435
Lines 40097 40109 +12
Branches 5212 5222 +10
==========================================
+ Hits 28348 28362 +14
- Misses 10095 10097 +2
+ Partials 1654 1650 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
arborite-rh
previously approved these changes
Feb 5, 2024
syed
force-pushed
the
fix-empty-config
branch
2 times, most recently
from
0d496df
to
5b3687f
Compare
Artifacts can have empty config defined skip parsing if the config is empty
syed
force-pushed
the
fix-empty-config
branch
from
5b3687f
to
c9a8677
Compare
arborite-rh
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifacts can have empty config defined
skip parsing if the config is empty