quota: removing repo size from quota verification (PROJQUAY-6637) #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
- Coverage 70.70% 70.69% -0.01%
==========================================
Files 436 436
Lines 40223 40221 -2
Branches 5228 5228
==========================================
- Hits 28438 28436 -2
- Misses 10127 10129 +2
+ Partials 1658 1656 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/cherry-pick redhat-3.10 |
|
@bcaton85: new pull request created: #2708 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sunandadadi
pushed a commit
to Sunandadadi/quay
that referenced
this pull request
Feb 27, 2024
…ay#2704) removing repo size from upload image size during quota verification
Sunandadadi
pushed a commit
to Sunandadadi/quay
that referenced
this pull request
Mar 5, 2024
…ay#2704) removing repo size from upload image size during quota verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During quota verification, Quay fetches the size of the image currently being uploaded. That method incorrectly added the repository size to the size of the image being uploaded. That total returned was then added to the namespace size resulting in the following check:
repo_size + namespace_size + uploaded blob > quota_size_limit. This causes the repo_size to be counted twice and images to be blocked early.