Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add auto-prune tests + fix namespace autoprune policy UI issue (PROJQUAY-6773) #2717

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

harishsurf
Copy link
Contributor

  • Adds more repository auto-prune tests
  • Fixes UI issue: when user is not an admin, the namespace autoprune policy under repository auto-prune policies tab shouldbe hidden

…UAY-6773)

Signed-off-by: harishsurf <hgovinda@redhat.com>
@harishsurf harishsurf requested a review from bcaton85 March 4, 2024 12:04
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.79%. Comparing base (74fd23d) to head (b2692e0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2717   +/-   ##
=======================================
  Coverage   70.79%   70.79%           
=======================================
  Files         436      436           
  Lines       40526    40526           
  Branches     5283     5283           
=======================================
+ Hits        28690    28691    +1     
- Misses      10159    10160    +1     
+ Partials     1677     1675    -2     
Flag Coverage Δ
unit 70.79% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bcaton85 bcaton85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harishsurf harishsurf enabled auto-merge (squash) March 4, 2024 15:17
@harishsurf harishsurf changed the title Add auto-prune tests + fix namespace autoprune policy UI issue (PROJQUAY-6773) chore: Add auto-prune tests + fix namespace autoprune policy UI issue (PROJQUAY-6773) Mar 4, 2024
@harishsurf harishsurf merged commit 0be8cb7 into quay:master Mar 4, 2024
19 of 20 checks passed
@harishsurf harishsurf deleted the autoprune-tests branch March 5, 2024 03:55
Sunandadadi pushed a commit to Sunandadadi/quay that referenced this pull request Mar 5, 2024
…UAY-6773) (quay#2717)

Signed-off-by: harishsurf <hgovinda@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants