ui: updating nginx routing rule for userfiles (PROJQUAY-6841) #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2735 +/- ##
==========================================
- Coverage 70.90% 70.90% -0.01%
==========================================
Files 436 436
Lines 40597 40596 -1
Branches 5285 5285
==========================================
- Hits 28784 28783 -1
- Misses 10139 10141 +2
+ Partials 1674 1672 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/cherry-pick redhat-3.11 |
|
@bcaton85: new pull request created: #2744 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload of dockerfile for dockerfile builds currently hits the
/userfiles/<id>endpoint in certain scenarios. From the new UI this routes to the react index.html resulting in a 405 method not found. This change routes all paths matching^/userfiles/(.*)to the API.