Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc: ask for group object id for azure oauth login (PROJQUAY-6917) #2805

Merged
merged 3 commits into from Apr 24, 2024

Conversation

Sunandadadi
Copy link
Contributor

Azure oauth:
Screenshot 2024-04-05 at 5 11 27 PM

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 70.92%. Comparing base (0de7f6f) to head (0bf91aa).
Report is 2 commits behind head on master.

❗ Current head 0bf91aa differs from pull request most recent head 12e661e. Consider uploading reports for the commit 12e661e to get more accurate results

Files Patch % Lines
data/users/externaloidc.py 33.33% 4 Missing ⚠️
data/users/__init__.py 82.35% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2805      +/-   ##
==========================================
- Coverage   70.93%   70.92%   -0.02%     
==========================================
  Files         436      436              
  Lines       40723    40733      +10     
  Branches     5323     5327       +4     
==========================================
+ Hits        28887    28890       +3     
- Misses      10152    10158       +6     
- Partials     1684     1685       +1     
Flag Coverage Δ
unit 70.92% <72.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@syed syed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sunandadadi Sunandadadi merged commit 81682c9 into quay:master Apr 24, 2024
17 checks passed
@Sunandadadi
Copy link
Contributor Author

/cherrypick redhat-3.11

@Sunandadadi Sunandadadi deleted the PROJQUAY-6917 branch April 24, 2024 14:25
@openshift-cherrypick-robot

@Sunandadadi: new pull request created: #2837

In response to this:

/cherrypick redhat-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants