Make sure we don't send zero value metrics to Prometheus in verbs #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `inc` function rejects these with an exception Fixes https://issues.redhat.com/browse/PROJQUAY-456
jzelinskie
approved these changes
Mar 25, 2020
|
@jzelinskie It shouldn't be, but there appears to be a bug somewhere in ACI generation that can lead to empty images. Since ACI is deprecated, I'd rather just patch this and wait for us to remove ACI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
incfunction rejects these with an exceptionFixes https://issues.redhat.com/browse/PROJQUAY-456