backend: implement basic functionality (PROJQUAY-7076) #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Sunandadadi and the rest of your teammates on |
Sunandadadi
changed the title
Sunandadadi
changed the title
Sunandadadi
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 05-20-db-updates #2895 +/- ##
====================================================
+ Coverage 70.35% 70.39% +0.04%
====================================================
Files 439 440 +1
Lines 41274 41359 +85
Branches 5410 5417 +7
====================================================
+ Hits 29037 29116 +79
- Misses 10531 10536 +5
- Partials 1706 1707 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sunandadadi
force-pushed
the
05-20-backend-base
branch
from
cf1e8fb
to
8c14fa0
Compare
Sunandadadi
force-pushed
the
05-20-db-updates
branch
from
aa86edd
to
7e94780
Compare
Sunandadadi
force-pushed
the
05-20-backend-base
branch
from
8c14fa0
to
71251ab
Compare
Sunandadadi
force-pushed
the
05-20-db-updates
branch
from
7e94780
to
6cd7f1a
Compare
Sunandadadi
force-pushed
the
05-20-backend-base
branch
4 times, most recently
from
7feafb2
to
d3bde12
Compare
Sunandadadi
force-pushed
the
05-20-backend-base
branch
2 times, most recently
from
f52dd3a
to
4d1b051
Compare
Sunandadadi
force-pushed
the
05-20-db-updates
branch
from
6cd7f1a
to
afe0f69
Compare
Sunandadadi
force-pushed
the
05-20-backend-base
branch
from
4d1b051
to
1e8e2f6
Compare
Sunandadadi
force-pushed
the
05-20-db-updates
branch
2 times, most recently
from
ed63988
to
2582626
Compare
Sunandadadi
force-pushed
the
05-20-backend-base
branch
6 times, most recently
from
0904b22
to
ad8c66b
Compare
Sunandadadi
force-pushed
the
05-20-backend-base
branch
from
ad8c66b
to
b401ab4
Compare
Sunandadadi
force-pushed
the
05-20-db-updates
branch
from
2582626
to
fcf8090
Compare
Sunandadadi
force-pushed
the
05-20-backend-base
branch
2 times, most recently
from
407a10a
to
1665b94
Compare
This was referenced Jun 6, 2024
Sunandadadi
force-pushed
the
05-20-db-updates
branch
2 times, most recently
from
4cc971d
to
c2c0150
Compare
Sunandadadi
force-pushed
the
05-20-backend-base
branch
from
1665b94
to
8cf4465
Compare
syed
reviewed
Jun 25, 2024
| RepositoryNotification.last_ran_ms | ||
| < get_epoch_timestamp_ms() - task_run_interval_ms | ||
| ) | ||
| | (RepositoryNotification.last_ran_ms.is_null(True)), |
There was a problem hiding this comment.
make sure last_ran_ms is indexed
There was a problem hiding this comment.
yes, added in index here
Sunandadadi
force-pushed
the
05-20-db-updates
branch
from
1b0cb30
to
606612c
Compare
syed
reviewed
Jun 25, 2024
| @@ -9,6 +9,7 @@ class RepositoryNotification( | |||
| namedtuple( | |||
| "RepositoryNotification", | |||
| [ | |||
There was a problem hiding this comment.
is this the DB ID? we shouldn't expose this to an external API
There was a problem hiding this comment.
yes, good point, I removed it
syed
reviewed
Jun 25, 2024
workers/gc/gcworker.py
Outdated
|
|
||
| def _scan_notifications(self): | ||
| # scan for tags that are expiring based on configured RepositoryNotifications | ||
| scan_for_image_expiry_notifications(event_name="repo_image_expiry") |
There was a problem hiding this comment.
can you use RepoImageExpiryEvent.event_name()
Sunandadadi
force-pushed
the
05-20-backend-base
branch
from
8cf4465
to
d67be20
Compare
Sunandadadi
force-pushed
the
05-20-backend-base
branch
from
d67be20
to
d1f7a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.