Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unknown Provider AngularJS Errors #394

Merged
merged 1 commit into from May 27, 2020

Conversation

alecmerdler
Copy link
Contributor

@alecmerdler alecmerdler commented May 26, 2020

Description

Add the right minification flags to Webpack's TerserPlugin to fix unknown provider error:

angular.min.js-f0f4228b82f7.js:116 Error: [$injector:unpr] http://errors.angularjs.org/1.5.3/$injector/unpr?p0=DocumentationServiceProvider%20%3C-%20DocumentationService%20%3C-%20ExternalNotificationData

Fixes https://issues.redhat.com/browse/PROJQUAY-732
Fixes https://issues.redhat.com/browse/PROJQUAY-733
Fixes https://issues.redhat.com/browse/PROJQUAY-734

@josephschorr
Copy link
Contributor

@alecmerdler can you fix that other instance where I had a typo in the DocumentationService name?

@alecmerdler
Copy link
Contributor Author

@josephschorr Fixed the typo.

Copy link
Contributor

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecmerdler alecmerdler merged commit 26c659e into quay:master May 27, 2020
@alecmerdler alecmerdler deleted the fix-documentation-service branch May 27, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants