Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the executor image from Container Linux to Fedora CoreOS #434

Merged
merged 13 commits into from Jul 14, 2020

Conversation

kleesc
Copy link
Member

@kleesc kleesc commented Jun 10, 2020

Description of Changes

Issue: PROJQUAY-704

TESTING ->

BREAKING CHANGE ->


Reviewer Checklist

  • It works!
  • Comments provide sufficient explanations for the next contributor
  • Tests cover changes and corner cases
  • Follows Quay syntax patterns and format

@kleesc kleesc requested a review from josephschorr June 10, 2020 18:31
@kleesc kleesc force-pushed the PROJQUAY-704-update-build-executor-image branch 8 times, most recently from 1f019f2 to 9a4ddf4 Compare July 6, 2020 19:46
@kleesc kleesc force-pushed the PROJQUAY-704-update-build-executor-image branch from 741c717 to 64a8fbe Compare July 6, 2020 20:19
@kleesc
Copy link
Member Author

kleesc commented Jul 13, 2020

@josephschorr Ping
Tested on both aws and qemu. Both were able to boot, but failed to connect back to Quay (as expected since it's being run locallty)

Jul 13 21:24:13 c3d2032b-6519-4f56-a35a-5c5a875ec540 docker[1835]: time="2020-07-13T21:24:13Z" level=info msg="55670558-ead8-4551-9a85-87bec83bc76e: attempting to connect to websocket wss://quay:8443/b1/socket"
Jul 13 21:24:13 c3d2032b-6519-4f56-a35a-5c5a875ec540 docker[1835]: time="2020-07-13T21:24:13Z" level=warning msg="55670558-ead8-4551-9a85-87bec83bc76e: Got error when connecting to build manager: dial tcp: look>
Jul 13 21:24:13 c3d2032b-6519-4f56-a35a-5c5a875ec540 docker[1835]: time="2020-07-13T21:24:13Z" level=info msg="55670558-ead8-4551-9a85-87bec83bc76e: Sleeping for 16 seconds (attempt #4 of 5)"
Jul 13 21:24:29 c3d2032b-6519-4f56-a35a-5c5a875ec540 docker[1835]: time="2020-07-13T21:24:29Z" level=info msg="55670558-ead8-4551-9a85-87bec83bc76e: attempting to connect to websocket wss://quay:8443/b1/socket"
Jul 13 21:24:29 c3d2032b-6519-4f56-a35a-5c5a875ec540 docker[1835]: time="2020-07-13T21:24:29Z" level=fatal msg="55670558-ead8-4551-9a85-87bec83bc76e: dial tcp: lookup quay on 10.0.2.3:53: no such host"
Jul 13 21:24:29 c3d2032b-6519-4f56-a35a-5c5a875ec540 systemd[1]: quay-builder.service: Main process exited, code=exited, status=1/FAILURE

Copy link
Contributor

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kleesc kleesc merged commit 08cfd7e into quay:master Jul 14, 2020
@kleesc kleesc deleted the PROJQUAY-704-update-build-executor-image branch July 14, 2020 16:55
@dustymabe
Copy link

🎉 Does this mean quay builders run on FCOS now?

@josephschorr
Copy link
Contributor

@dustymabe Once its tested and deployed and not on prem (yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants