[PROJQUAY-917] Fix CSRF token encoding #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/PROJQUAY-917
Changelog: Fix CSRF token encoding in Python 3
Docs: n/a
Testing: Using any form in the UI, such as creating a User, should no longer fail with a CSRF token error.
Details: The CSRF token is being encoded in a way that causes the front-end to incorrectly escape certain sequences contained within the token. This causes CSRF validation to fail as the token created by the back-end and stored in the session does not match what is sent by the browser. This change fixes that issue.