Fallback to reading 0 bytes if readable is not implemented. #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleesc
force-pushed
the
filelike-for-gunicorn-wsgi-wrap
branch
from
57a040c
to
baae1e9
Compare
| fileobj = BytesIO(b"this will not really be a real fileobj") | ||
| body = Body(fileobj) | ||
| ls = LimitingStream(body) | ||
| assert ls.readable() |
There was a problem hiding this comment.
Execute a read as well, and ensure it finds the correct data and is limited
Gunicorn will wrap the wsgi stream in its own wrapper class (see `class Body`). This class is not compliant with the file-object api from Python (missing `readable`). This issue never showed up before because of https://github.com/quay/quay/blob/master/storage/swift.py#L418 always evaluating to False in Python2, which was fixed by quay#508.
kleesc
force-pushed
the
filelike-for-gunicorn-wsgi-wrap
branch
from
baae1e9
to
3eea33d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gunicorn will wrap the wsgi stream in its own wrapper class (see
class Body).This class is not compliant with the file-object api from Python (missing
readable).This issue never showed up before because of
https://github.com/quay/quay/blob/master/storage/swift.py#L418 always evaluating to
Falsein Python2 whichwas fixed by #508.
Issue: https://issues.redhat.com/browse/PROJQUAY-941
Changelog:
Docs:
Testing:
Details: