Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROJQUAY-1020 chore: Fix cdnjs download failure(403) by setting custom User-Agent req header #535

Merged
merged 3 commits into from Aug 31, 2020

Conversation

arajkumar
Copy link
Contributor

Issue: https://issues.redhat.com/browse/PROJQUAY-1020

Testing:

Details:
Looks like cdjs is not happy with the default user-agent string set from python urllib.

Copy link
Contributor

@thomasmckay thomasmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasmckay thomasmckay merged commit f9249d8 into quay:master Aug 31, 2020
kleesc pushed a commit to kleesc/quay that referenced this pull request Oct 14, 2020
…m User-Agent req header (quay#535)

* fix: cdnjs download failure(403) by setting custom User-Agent req header

* Update UA string

* chore: Version lock black to 19.10b0
kleesc added a commit that referenced this pull request Oct 14, 2020
* PROJQUAY-1020 chore: Fix cdnjs download failure(403) by setting custom User-Agent req header (#535)

* fix: cdnjs download failure(403) by setting custom User-Agent req header

* Update UA string

* chore: Version lock black to 19.10b0

* Make sure to cleanup started executors when falling back to next executor

Co-authored-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants