Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROJQUAY-45] Specify new-installation migration for 3.2. #55

Merged
merged 1 commit into from
Dec 5, 2019
Merged

[PROJQUAY-45] Specify new-installation migration for 3.2. #55

merged 1 commit into from
Dec 5, 2019
+3 −0

Conversation

kurtismullins
Copy link
Contributor

@kurtismullins kurtismullins commented Dec 5, 2019 •
edited

Description of Changes

This should allow the image to be executed successfully without manually providing the environment variable ENCRYPTED_ROBOT_TOKEN_MIGRATION_PHASE.

Additionally, users who want to take advantage of the 5-phase migration can do so by overriding the environment variable upon startup/deployment.

Changes:

  • Modified RHEL Dockerfile to specify a default for the migration environment variable.

Issue:

TESTING

  1. Build the Image
  2. Run it without overriding the environment variable. It should start as expected and perform the migration in whole.
  3. Run it while specifying another value for the environment variable. It should start running the associated migration.

More detail is included in the referenced Jira story.

BREAKING CHANGE

n/a

Reviewer Checklist

  • It works!
  • Comments provide sufficient explanations for the next contributor
  • Tests cover changes and corner cases
  • Follows Quay syntax patterns and format

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

thomasmckay
thomasmckay approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@thomasmckay thomasmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kurtismullins kurtismullins merged commit 3407b7c into quay:3.2.0-release Dec 5, 2019
dmage pushed a commit to dmage/quay that referenced this pull request Jul 28, 2023
@jonathankingfc
Merge pull request quay#55 from quay/checkBucket
03f53aa 
Check bucket exists in Minio gateway validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasmckay thomasmckay thomasmckay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@kurtismullins @app-sre-bot @thomasmckay