GitHub Actions set-env deprecation #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Announced on October 1st, [set-env is being deprecated](https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/) and we've started to see warnings in various workflow runs that use it. I noticed you use it here, and wanted to offer a quick fix.
|
Can one of the admins verify this patch? |
hdonnay
requested changes
Oct 13, 2020
Co-authored-by: Hank Donnay <hdonnay@gmail.com>
hdonnay
approved these changes
Oct 13, 2020
|
Thanks @hdonnay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/PROJQUAY-1141
Changelog: none
Docs: none
Testing: none
Details:
Announced on October 1st, set-env is being deprecated and we've started to see warnings in various workflow runs that use it. I noticed you use it here, and wanted to offer a quick fix. I tested it out for my own workflow (thanks @jzelinskie for the tip!) here if you want to see if it works as expected to compile the conformance.test binary.