Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --shrink flag when resizing the qemu image. #635

Merged
merged 1 commit into from Jan 4, 2021

Conversation

kleesc
Copy link
Member

@kleesc kleesc commented Jan 4, 2021

Newer version of qemu will return a non-zero error when --shrink is not set when resizing an image.

Issue: https://issues.redhat.com/browse/PROJQUAY-1402

Changelog:

  • Add --shrink to the qemu-img resize command

Docs:

Testing:

Details:

Newer version of qemu will return a non-zero error when --shrink is not set when resizing an image.
Copy link
Contributor

@thomasmckay thomasmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kleesc kleesc merged commit 709e487 into quay:master Jan 4, 2021
@kleesc kleesc deleted the shrink-flag-qemu-resize branch January 4, 2021 16:19
kleesc added a commit to kleesc/quay that referenced this pull request Jan 4, 2021
Newer version of qemu will return a non-zero error when --shrink is not set when resizing an image.
kleesc added a commit that referenced this pull request Jan 4, 2021
Newer version of qemu will return a non-zero error when --shrink is not set when resizing an image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants