Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autobahn package #641

Merged
merged 1 commit into from Jan 5, 2021
Merged

Conversation

kleesc
Copy link
Member

@kleesc kleesc commented Jan 5, 2021

Issue: https://issues.redhat.com/browse/PROJQUAY-1406
Changelog:

  • Removes autobahn from dependencies

Docs:

Testing:

Details:

Copy link
Contributor

@thomasmckay thomasmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update requirements-osbs.txt as well.

Are there related packages that can now be removed as well? https://github.com/release-engineering/cachito/blob/master/docs/pip.md

@kleesc
Copy link
Member Author

kleesc commented Jan 5, 2021

@thomasmckay Done. You can double check, but I don't think there's any package standing out that depends directly on autobahn.

Copy link
Contributor

@thomasmckay thomasmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kleesc kleesc merged commit 7064e9e into quay:master Jan 5, 2021
@kleesc kleesc deleted the remove-unused-pip-packages branch January 5, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants