Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: abort unfinished mpu when no bytes are written #705

Merged
merged 1 commit into from Mar 24, 2021
Merged

storage: abort unfinished mpu when no bytes are written #705

merged 1 commit into from Mar 24, 2021

Conversation

kleesc
Copy link
Member

@kleesc kleesc commented Mar 24, 2021

Explicitly call abort on a mpu if no bytes were written.
Noobaa and Rados will not clean the artifacts, resulting in empty
files being stuck in an "uploading" state.

Issue: https://issues.redhat.com/browse/PROJQUAY-1123

Changelog:

  • Explicitly abort MultipartUpload where no bytes were uploaded

Docs:

Testing:

Details:

@kleesc
storage: abort unfinished mpu when no bytes were written
e195dd4 
Explicitly call abort on a mpu if no bytes were written.
Noobaa and Rados will not clean the artifacts, resulting in empty
files being stuck in an "uploading" state.
@kleesc kleesc requested a review from thomasmckay March 24, 2021 18:53
@kleesc kleesc changed the title storage: abort unfinished mpu when no bytes were written storage: abort unfinished mpu when no bytes are written Mar 24, 2021
thomasmckay
thomasmckay approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@thomasmckay thomasmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kleesc kleesc merged commit e0d39fe into quay:master Mar 24, 2021
@kleesc kleesc deleted the abort-empty-mpu branch March 24, 2021 21:43
@kleesc kleesc mentioned this pull request Mar 24, 2021
Closed
kleesc added a commit to kleesc/quay that referenced this pull request May 12, 2021
@kleesc
storage: abort unfinished mpu when no bytes were written (quay#705)
069ebcb 
Explicitly call abort on a mpu if no bytes were written.
Noobaa and Rados will not clean the artifacts, resulting in empty
files being stuck in an "uploading" state.
kleesc added a commit that referenced this pull request May 12, 2021
@kleesc
storage: abort unfinished mpu when no bytes were written (#705) (#789)
16f9b5d 
Explicitly call abort on a mpu if no bytes were written.
Noobaa and Rados will not clean the artifacts, resulting in empty
files being stuck in an "uploading" state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasmckay thomasmckay thomasmckay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@kleesc @thomasmckay