Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration: drop uploading column from imagestorage (PROJQUAY-1899) #767

Closed

Conversation

kleesc
Copy link
Member

@kleesc kleesc commented Apr 21, 2021

Follow up to 4ad5a45. Drop deprecated uploading column from
ImageStorage table.

@kleesc kleesc requested review from syed and alecmerdler April 21, 2021 18:01
syed
syed previously approved these changes Apr 22, 2021
Copy link
Contributor

@syed syed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one minor correction

Follow up to 4ad5a45. Drop deprecated uploading column from
ImageStorage table.
syed
syed previously approved these changes Apr 27, 2021
@kleesc
Copy link
Member Author

kleesc commented Apr 27, 2021

@syed Holding off merging this. In theory, this should be done without downtime, but still remains an expensive op. Will likely need a maintenance window for this.

Ref:

Also, the current alembic versions are no longer valid after #769 was merged.

@kleesc kleesc dismissed syed’s stale review April 27, 2021 16:54

Still need updates

@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2022

@kleesc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kleesc kleesc closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants