ui: change angular routing order for repo paths (PROJQUAY-2325) #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleesc
force-pushed
the
ui-route-order-for-repo-named-groups
branch
3 times, most recently
from
16d8b3c
to
d633ab7
Compare
|
@jonathankingfc @Sunandadadi PTAL when you have some time. |
Unlike Flask, Angular does not use weights to match paths to routes,
so order matters. In order to support repository with "/" in them, we
previously added "*" to the repository name named group, allowing it
to capture subsequent "/". When that's the case, it is important that
to general "catch-all" route comes after the more specific routes (e.g
repo manifest). Otherwise, Angular will just eagerly use the first
route that matches a path, even though it may have "better" match in
subsequent routes.
e.g - '/api/v1/repository/:namespace/:name*'
- '/api/v1/repository/:namespace/:name*\/tag/:tag'
In this case, something like
/api/v1/repository/devtable/testrepo/tag/testtag would match the
first route, even though if using a weighted system, the second
route in most case be a better fit.
kleesc
force-pushed
the
ui-route-order-for-repo-named-groups
branch
from
d633ab7
to
8f02bf7
Compare
Sunandadadi
approved these changes
Aug 17, 2021
kleesc
added a commit
to kleesc/quay
that referenced
this pull request
Aug 17, 2021
…#872) Unlike Flask, Angular does not use weights to match paths to routes, so order matters. In order to support repository with "/" in them, we previously added "*" to the repository name named group, allowing it to capture subsequent "/". When that's the case, it is important that to general "catch-all" route comes after the more specific routes (e.g repo manifest). Otherwise, Angular will just eagerly use the first route that matches a path, even though it may have "better" match in subsequent routes. e.g - '/api/v1/repository/:namespace/:name*' - '/api/v1/repository/:namespace/:name*\/tag/:tag' In this case, something like /api/v1/repository/devtable/testrepo/tag/testtag would match the first route, even though if using a weighted system, the second route in most case be a better fit.
kleesc
added a commit
that referenced
this pull request
Aug 17, 2021
* migration: configure logging in alembic's env.py (PROJQUAY-2412) (#875) Reference: https://alembic.sqlalchemy.org/en/latest/api/config.html#configuration * ui: change angular routing order for repo paths (PROJQUAY-2325) (#872) Unlike Flask, Angular does not use weights to match paths to routes, so order matters. In order to support repository with "/" in them, we previously added "*" to the repository name named group, allowing it to capture subsequent "/". When that's the case, it is important that to general "catch-all" route comes after the more specific routes (e.g repo manifest). Otherwise, Angular will just eagerly use the first route that matches a path, even though it may have "better" match in subsequent routes. e.g - '/api/v1/repository/:namespace/:name*' - '/api/v1/repository/:namespace/:name*\/tag/:tag' In this case, something like /api/v1/repository/devtable/testrepo/tag/testtag would match the first route, even though if using a weighted system, the second route in most case be a better fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike Flask, Angular does not use weights to match paths to routes,
so order matters. In order to support repository with "/" in them, we
previously added "*" to the repository name named group, allowing it
to capture subsequent "/". When that's the case, it is important that
to general "catch-all" route comes after the more specific routes (e.g
repo manifest). Otherwise, Angular will just eagerly use the first
route that matches a path, even though it may have "better" match in
subsequent routes.
e.g - '/api/v1/repository/:namespace/:name*'
- '/api/v1/repository/:namespace/:name*/tag/:tag'