chore(Dockerfile): add local dev env target (PROJQUAY-2501) #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
flavianmissi
force-pushed
the
local-dev-dockerfile
branch
from
f5b80cb
to
f3f80f5
Compare
kleesc
reviewed
Sep 15, 2021
| context: . | ||
| dockerfile: ./local-dev/Dockerfile | ||
| target: local-dev-env |
There was a problem hiding this comment.
Oh, I didn't know you could stop at specific stage. That's neat.
kleesc
previously approved these changes
Sep 15, 2021
|
@flavianmissi I think the commit check is not passing because the ticket is missing from your commit header (it's in the Github PR's title, but not in the actual git commit). |
Ooh that makes sense! I'll fix then merge. Thx for reviewing! |
When specified, the new build target (aka stage) builds quay the way local-dev/Dockerfile used to, using local-dev/config.yml as configuration, and starting up only the necessary tools for development. See docker-compose.yml services:quay:build:target for how it's used. Production builds should not be affected since the new target is not referenced from anywhere but the docker-compose.yml.
flavianmissi
force-pushed
the
local-dev-dockerfile
branch
from
f3f80f5
to
b8de073
Compare
|
@kleesc I reworded the commit so all checks would pass but now I need another approval 😅 |
crozzy
pushed a commit
to crozzy/quay
that referenced
this pull request
Sep 17, 2021
…y#883) When specified, the new build target (aka stage) builds quay the way local-dev/Dockerfile used to, using local-dev/config.yml as configuration, and starting up only the necessary tools for development. See docker-compose.yml services:quay:build:target for how it's used. Production builds should not be affected since the new target is not referenced from anywhere but the docker-compose.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run a local development environment we currently use docker-compose with the custom
local-dev/Dockerfile.For better reuse of the improvements made to
Dockerfile, the specific bits oflocal-dev/Dockerfilehave been moved toDockerfileas a build stage calledlocal-dev-env, andlocal-dev/Dockerfilehas been removed. This change also ensures that future improvements toDockerfilewill automatically be reused in our local dev envs.NOTE:fixed in #885setuptoolsversion had to be pinned to 57.5.0. Versions >=58 break the installation of funcparserlib