notification: check certs exists for webhooks (PROJQUAY-2424) #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the Quay key/cert pair (ssl.key + ssl.cert) have been mounted/exists whenever it tries sending a webhook request with client cert. If that's not the case, then the webhook is sent without client cert. This can happen when TLS is not handled by the Quay container, in which case these certs are not required by default in the Quay container.
kleesc
requested review from
flavianmissi,
ricardomaraschini and
jonathankingfc
flavianmissi
approved these changes
Sep 13, 2021
crozzy
pushed a commit
to crozzy/quay
that referenced
this pull request
Sep 17, 2021
Make sure the Quay key/cert pair (ssl.key + ssl.cert) have been mounted/exists whenever it tries sending a webhook request with client cert. If that's not the case, then the webhook is sent without client cert. This can happen when TLS is not handled by the Quay container, in which case these certs are not required by default in the Quay container.
kleesc
added a commit
to kleesc/quay
that referenced
this pull request
Sep 22, 2021
Make sure the Quay key/cert pair (ssl.key + ssl.cert) have been mounted/exists whenever it tries sending a webhook request with client cert. If that's not the case, then the webhook is sent without client cert. This can happen when TLS is not handled by the Quay container, in which case these certs are not required by default in the Quay container.
kleesc
added a commit
that referenced
this pull request
Sep 22, 2021
…900) * notification: check certs exists for webhooks (PROJQUAY-2424) (#886) Make sure the Quay key/cert pair (ssl.key + ssl.cert) have been mounted/exists whenever it tries sending a webhook request with client cert. If that's not the case, then the webhook is sent without client cert. This can happen when TLS is not handled by the Quay container, in which case these certs are not required by default in the Quay container. * ci: Update funcparserlib version (PROJQUAY-2520) (#893) Updating funcparserlib to 1.0.0a0 fixes the issue initially addressed in d3809b2. * ci: pin oci test to a specific sha (PROJQUAY-2570) This pins the distribution-spec repo to a specific sha to prevent failing CI because of a change in the source test Signed-off-by: harishsurf <hgovinda@redhat.com> Co-authored-by: Harish Govindarajulu <hgovinda@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the Quay key/cert pair (ssl.key + ssl.cert) have been
mounted/exists whenever it tries sending a webhook request with client
cert. If that's not the case, then the webhook is sent without client
cert. This can happen when TLS is not handled by the Quay container,
in which case these certs are not required by default in the Quay
container.