registry: update blob mount behaviour when from parameter is missing (PROJQUAY-2570) #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleesc
force-pushed
the
blob-mount-fallback-behaviour
branch
2 times, most recently
from
27a9c10
to
c2e039e
Compare
…(PROJQUAY-2570) Update the behaviour when attempting to mount existing blob whenever the `from` parameter is missing. Currently, Quay throws an Bad Request error whenever the `from parameter is missing. However, according to the specs (Docker Registry and OCI dist-spec), we should be falling back to the default upload behaviour. References: - https://docs.docker.com/registry/spec/api/#pushing-an-image - https://github.com/opencontainers/distribution-spec/blob/main/spec.md#mounting-a-blob-from-another-repository - https://github.com/opencontainers/distribution-spec/pull/275/files
kleesc
changed the title
kleesc
force-pushed
the
blob-mount-fallback-behaviour
branch
from
c2e039e
to
7b7c55c
Compare
flavianmissi
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the behaviour when attempting to mount existing blob whenever
the
fromparameter is missing. Currently, Quay throws an Bad Requesterror whenever the `from parameter is missing. However, according to
the specs (Docker Registry and OCI dist-spec), we should be falling
back to the default upload behaviour.
References: