Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build and publish workflow (PROJQUAY-2556) #912

Merged
merged 1 commit into from Oct 7, 2021

Conversation

flavianmissi
Copy link
Contributor

No description provided.

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

env:
BRANCH_PREFIX: redhat- # IMPORTANT! this must match the .on.push.branches prefix!
REGISTRY: quay.io/projectquay
REPO_NAME: ${{ github.event.repository.name }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this quay, or quay/quay. In either case, is ${{ env.REGISTRY }}/${{ env.REPO_NAME }}:${{ env.TAG }} below correct?

Otherwise LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: If built from redhat-3.5 branch for example, then ${{ env.REGISTRY }}/${{ env.REPO_NAME }}:${{ env.TAG }} is evaluated to quay.io/projectquay/quay:3.5-unstable.

REPO_NAME is evaluated to quay. Check this out https://github.com/flavians-test-org/build-me/runs/3755985838?check_suite_focus=true, and expand the Echo repository name step.
The workflow used there is nearly identical the one in this PR: https://github.com/flavians-test-org/build-me/actions/runs/1291052126/workflow#L15
And the generated tags for my tests: https://quay.io/repository/fmissi/build-me?tag=latest&tab=tags

@flavianmissi flavianmissi merged commit 16dcebf into quay:master Oct 7, 2021
@flavianmissi flavianmissi deleted the build-workflow branch October 7, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants