Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetch-node.js for fixes node-fetch for webpack. #192

Closed
wants to merge 1 commit into from

Conversation

lygstate
Copy link

Or we can not use webpack to pack packages that depends on fetch-ponyfill

Or we can not use webpack to pack packages that depends on fetch-ponyfill
@qubyte
Copy link
Owner

qubyte commented Jul 14, 2019

I don’t understand. Why are you modifying the node-fetch to work with webpack? It’s meant for direct use by node only, not the browser.

@lygstate
Copy link
Author

@qubyte pack it into a single js file for distribution easily:) like binary

@qubyte
Copy link
Owner

qubyte commented Jul 14, 2019

Sorry, there is no reason to package modules published to npm in this way when node is the environment targeted. The node module system works just fine with many individual files.

@qubyte qubyte closed this Jul 14, 2019
@Lazyshot Lazyshot mentioned this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants