Error handler #40
Merged
Error handler #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring's DefaultErrorWebExceptionHandler isn't aware of the logging context, leading to errors being logged without context. This PR reimplements it.
I had to move the LoggingContextFilter to a LoggingContextWebHandler, as the reactive context can only be seen by the operators above it. That's not ideal, but Spring doesn't let us wrap around the ErrorWebExceptionHandler, it's the "outer-most filter", hardcoded unfortunately, hence having to rewrite the WebHandler too.