Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koa v2 middleware support #54

Merged
merged 5 commits into from Mar 15, 2016
Merged

Koa v2 middleware support #54

merged 5 commits into from Mar 15, 2016

Conversation

@ifraixedes
Copy link
Contributor

ifraixedes commented Mar 1, 2016

This PR provide a version of this module to use with Koa V2.

I've implemented in native promises as discussed on #52

Because Koa v2 is still in alpha due the lack of native support for async/await functions in NodeJS, this PR should be merged in this repo in a new branch, rather than master, as other koa-* repos does (e.g. koa-path-match); I've sent PR to maste to show the changes, let me know if you prefer to send this PR on a new branch when you create it.

To release this version, Koa is using @next named version in npm, so people can install koa v2 middlewares just doing npm install koa-xxxx@next

On the other hand, I also added eslint and a standard configuration; I think that repos should have one and took an standard one than the one that I've usually used.

@ifraixedes ifraixedes mentioned this pull request Mar 1, 2016
@tuananh

This comment has been minimized.

Copy link

tuananh commented Mar 3, 2016

👍

@ifraixedes

This comment has been minimized.

Copy link
Contributor Author

ifraixedes commented Mar 12, 2016

Please, provide me feedback to know if I should do something for this PR could be merged.

Thanks.

@ianstormtaylor

This comment has been minimized.

Copy link

ianstormtaylor commented Mar 15, 2016

Any update on this? Would love to see Koa 2.0 support added!

@queckezz

This comment has been minimized.

Copy link
Owner

queckezz commented Mar 15, 2016

Thanks for the pull-request, really awesome! Haven't been able to review this until now. I'm going to merge this with master and keep a v1.x branch since master should always be the latest version.

queckezz added a commit that referenced this pull request Mar 15, 2016
Koa v2 middleware support. Thanks @ifraixedes!
@queckezz queckezz merged commit 490ddea into queckezz:master Mar 15, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@queckezz

This comment has been minimized.

Copy link
Owner

queckezz commented Mar 15, 2016

Alright, published as 5.0.0 or next

λ npm dist-tag add koa-views@5.0.0 next
+next: koa-views@5.0.0

λ npm dist-tag add koa-views@4.1.0 latest
+latest: koa-views@4.1.0

Hopefully I did everything correctly. Thanks again for the PR, really appreciated.

@queckezz

This comment has been minimized.

Copy link

queckezz commented on index.js in aa3715b Mar 15, 2016

Can we remove those 3 lines?

@ifraixedes

This comment has been minimized.

Copy link
Contributor Author

ifraixedes commented Mar 15, 2016

Thanks for merging it.

@queckezz sure, I forgot to get rid of them

@queckezz queckezz mentioned this pull request Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.