Koa v2 middleware support #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
👍 |
|
Please, provide me feedback to know if I should do something for this PR could be merged. Thanks. |
|
Any update on this? Would love to see Koa |
|
Thanks for the pull-request, really awesome! Haven't been able to review this until now. I'm going to merge this with |
queckezz
added a commit
that referenced
this pull request
Mar 15, 2016
Koa v2 middleware support. Thanks @ifraixedes!
|
Alright, published as λ npm dist-tag add koa-views@5.0.0 next
+next: koa-views@5.0.0
λ npm dist-tag add koa-views@4.1.0 latest
+latest: koa-views@4.1.0Hopefully I did everything correctly. Thanks again for the PR, really appreciated. |
|
Thanks for merging it. @queckezz sure, I forgot to get rid of them |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provide a version of this module to use with Koa V2.
I've implemented in native
promisesas discussed on #52Because Koa v2 is still in alpha due the lack of native support for
async/awaitfunctions in NodeJS, this PR should be merged in this repo in a new branch, rather than master, as other koa-* repos does (e.g. koa-path-match); I've sent PR to maste to show the changes, let me know if you prefer to send this PR on a new branch when you create it.To release this version, Koa is using
@nextnamed version innpm, so people can install koa v2 middlewares just doingnpm install koa-xxxx@nextOn the other hand, I also added
eslintand a standard configuration; I think that repos should have one and took an standard one than the one that I've usually used.