fix: parse classnames both as string (with tagname), and as "class" attribute #1
Conversation
…ttribute
Fixes when you have a usecase like this (which didn't work)
```
h('div.one', {class: {two: true}}, [...])`
```
It made the class `one [object Object]`
This fixes it.
laggingreflex
force-pushed
the
fix/classnames
branch
from
76ae597
to
81836c9
Compare
classnames defined in tha tagname should come before the ones defiend in "class" attributes.
| Object.keys(attrs.class).forEach(existing => { | ||
| newClassesObj[existing] = attrs.class[existing] | ||
| }) | ||
| attrs.class = newClassesObj |
There was a problem hiding this comment.
This is to preserve order. Classnames defined with tagname should come first (IMO).
|
Awesome! Can you add a test for it? |
|
added tests f97194c |
test/index.js
Outdated
| const obj = parse(['p.italic', { class: 'bold' }]) | ||
| t.equal(obj.attrs.class, 'italic bold') | ||
| t.end() | ||
| }) | ||
|
|
||
| test('parse selector class with attributes class as array', (t) => { | ||
| const obj = parse(['p.italic', { class: ['bold'] }]) | ||
| t.deepEqual(obj.attrs.class, ['italic', 'bold']) |
There was a problem hiding this comment.
I don't understand how obj.attrs.class would be anything else than a string or an object.
based on the definitions, no array support is included in preact
There was a problem hiding this comment.
preact-hyperscript supports it (it passes it through classNames) https://github.com/queckezz/preact-hyperscript/blob/master/src/index.js#L30
There was a problem hiding this comment.
I guess I see now when you originally said that this could be a lot of extra code. If you don't want this to be in parse-hyperscript, and rather this should only be done in preact-hyperscript if it's the one that supports classNames then for this very specific use case (classname as array) it might require doing the work of this PR in preact-hyperscript itself (and even then probably here as well). Ah well, let me know how you wanna proceed
Fixes when you have a usecase like this (which didn't work)
It made the class
[object Object] oneThis fixes it.
Fixes queckezz/preact-hyperscript#3