Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add season plugin option #2

Closed
raae opened this issue Nov 13, 2021 · 4 comments · Fixed by #11
Closed

Add season plugin option #2

raae opened this issue Nov 13, 2021 · 4 comments · Fixed by #11
Labels
claimed Someone is working on it

Comments

@raae
Copy link
Member

raae commented Nov 13, 2021 •
edited
Loading

At the moment it's always on.

It should be able to set and forget, having it stop/start for each holiday season...
@raae raae changed the title Add timeframe plugin option Add calendar period plugin option Nov 13, 2021
@raae
Copy link
Member Author

raae commented Nov 13, 2021

Maybe name the option "season":

season: {
   start: <date>
   end: <date>
}

@raae raae changed the title Add calendar period plugin option Add season plugin option Nov 13, 2021
@raae
Copy link
Member Author

raae commented Nov 13, 2021

We could add default - November 15th to December 31st ?

@raae
Copy link
Member Author

raae commented Nov 14, 2021 •
edited
Loading

WP calls it snow_season and it was December 1st and January 4th.

@raae raae mentioned this issue Nov 15, 2021
Closed
@raae raae added the claimed Someone is working on it label Nov 15, 2021
@PaulieScanlon
Copy link
Contributor

@raae I've created a PR for a first attempt for how we could do the season option pull/11

raae added a commit that referenced this issue Dec 3, 2021
@raae
feat: season-plugin-option, solves #2 (#11)
9319fa0 
* feat: add season start and end

* feat: add pluginOptionsSchema for season

* chore: update README with time included in date string

* chore: blast - add seconds to end time string

* chore: test max time in seconds

* chore: add date-fns package

* docs: update readme

* fix: better defaults

* feat: only do snow when in season

* chore: full config of plugin in demo

* chore: only rely on schema defaults

* fix: catch all possible season errors

Co-authored-by: Benedicte Raae <raae@raae.codes>
raae-bot pushed a commit that referenced this issue Dec 3, 2021
@semantic-release-bot
chore(release): 0.4.0 [skip ci]
3b1f222 
# [0.4.0](v0.3.0...v0.4.0) (2021-12-03)

### Features

* season-plugin-option, solves [#2](#2) ([#11](#11)) ([9319fa0](9319fa0))
@raae raae linked a pull request Dec 3, 2021 that will close this issue
feat/season-plugin-option #11
Merged
@raae raae closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
claimed Someone is working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat/season-plugin-option PaulieScanlon/gatsby-plugin-let-it-snow
2 participants
@raae @PaulieScanlon