Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize db before server listen #34

Closed
glebec opened this issue Mar 5, 2017 · 1 comment
Closed

Synchronize db before server listen #34

glebec opened this issue Mar 5, 2017 · 1 comment

Comments

@glebec
Copy link
Contributor

glebec commented Mar 5, 2017

There is a race condition in the server start; it listens on a port without waiting for the database to finish syncing. While this almost certainly will not cause any problems in practice (how often does a request come in during the interval between starting the server and the db syncing?), it will be easy enough to implement the fix and demonstrate good practices.

@glebec
Copy link
Contributor Author

glebec commented Mar 6, 2017

Closing following comments in https://github.com/FullstackAcademy/bones/issues/64.

@glebec glebec closed this as completed Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant