Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PvP Leaderboards #15

Closed
darthmaim opened this issue Jan 22, 2017 · 1 comment
Closed

PvP Leaderboards #15

darthmaim opened this issue Jan 22, 2017 · 1 comment

Comments

@darthmaim
Copy link
Contributor

darthmaim commented Jan 22, 2017 •
edited

With the current implementation its not possible to get the leaderboards of the old pvp seasons, beacause the leaderboard was not called ladder, but legendary and guild (ref).

The name of future leaderboards might change again, so its probably a good idea to not hardcode the leaderboard name.

Edit: And another thing I just noticed, you haven't marked the leaderboard endpoint as paginated, but it is (example: requesting rank 200 (?page=199&page_size=1)).
queicherius added a commit that referenced this issue Jan 22, 2017
@queicherius
Fix PvP leaderboard implementation (#15)
e8145e0 
With the previous implementation it wasn't possible to access all the
information (boards and paginated content) correctly.

This is a breaking change, because the old syntax will be removed:
  `api().pvp().seasons(:id).leaderboards().ladder(:region)`
is now
  `api().pvp().seasons(:id).leaderboards().board(:board, :region)`
@queicherius
Copy link
Owner

Thank you for catching that, both things fixed in v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darthmaim @queicherius