Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update params for TileWMS and ImageWMS #199

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Update params for TileWMS and ImageWMS #199

merged 1 commit into from
Oct 9, 2018

Conversation

samuel-girard
Copy link

Hello,

When updating params input for TileWMS and ImageWMS, the source is not updated. This is important for time-based or elevation-based imagery layers.
This PR fixes this.
See corresponding API on OpenLayers:

aymeric-duchein
aymeric-duchein approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@aymeric-duchein aymeric-duchein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Neonox31 Neonox31 merged commit ba78923 into quentinlampin:next Oct 9, 2018
@samuel-girard samuel-girard deleted the feat-source-update branch October 9, 2018 12:18
Neonox31 pushed a commit that referenced this pull request Oct 26, 2018
@samuel-girard @Neonox31
feat(source): update params when input changes (TileWMS and ImageWMS) (…
f7578a4 
…#199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymeric-duchein aymeric-duchein aymeric-duchein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuel-girard @aymeric-duchein @Neonox31