Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Camera an Actor and improve performance #67

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Make Camera an Actor and improve performance #67

wants to merge 14 commits into from

Commits on Dec 12, 2023

  1. Whoops... forgot to update examples again.

    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    3c34ae4 View commit details
    Browse the repository at this point in the history

  2. Whoops... forgot to update README again.

    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c0935d2 View commit details
    Browse the repository at this point in the history

  3. Moved camera out of world and into a separate property of ScintillaAp… 

    …p. Also removed all async calls in World.
    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e4ff6ce View commit details
    Browse the repository at this point in the history

  4. Temporarily disabled running of tests; constructors in World are now … 

    …chained.
    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    72b6d63 View commit details
    Browse the repository at this point in the history

  5. OMFG I think I solved the performance issue.

    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    02d6a3f View commit details
    Browse the repository at this point in the history

  6. Updated TDOR sketch

    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    1c22485 View commit details
    Browse the repository at this point in the history

  7. Moved includes() into Shape protocol and made Group and CSG have sp… 

    …ecilalizatons of that method to avoid using a switch and casting. Also now passing IDs instead of entire shapes, all to avoid copying and adding performance overhead.
    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    554c4d4 View commit details
    Browse the repository at this point in the history

  8. Made code in CSG.filterInterections() a wee bit clearer.

    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    277f52f View commit details
    Browse the repository at this point in the history

  9. Cache in World is now only for maintaining the relationship between c… 

    …hild shape IDs to their parents. Consequently, parentId is no longer a nullable property of Shape.
    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    582883b View commit details
    Browse the repository at this point in the history

  10. Two things in this commit: we are now caching child IDs in CSG shapes… 

    … to speed up lookups, and we promoted the top level intersect function to be part of the Shape protocol to improve performance further.
    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    475e859 View commit details
    Browse the repository at this point in the history

  11. Updated all examples.

    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    541c7e3 View commit details
    Browse the repository at this point in the history

  12. Updated README.

    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d3dfd1b View commit details
    Browse the repository at this point in the history

  13. Updated tests and got them all to pass.

    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6d17348 View commit details
    Browse the repository at this point in the history

  14. Finally made Camera an actor and updated tests.

    @quephird
    quephird committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7bea988 View commit details
    Browse the repository at this point in the history