Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guava to latest version #931

Closed
SchulteMarkus opened this issue Sep 10, 2014 · 9 comments
Closed

Update guava to latest version #931

SchulteMarkus opened this issue Sep 10, 2014 · 9 comments
Milestone

Comments

@SchulteMarkus
Copy link

@SchulteMarkus SchulteMarkus commented Sep 10, 2014

Please update guava to latest version. For time being, querydsl is using version 14.0;latest stable is 18.0[1].

There are known bugs meanwhile fixed in guava18.0. In special, 14.0 is not deployable to JavaEE7 containers[2].

[1] http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22com.google.guava%22%20AND%20a%3A%22guava%22
[2] https://code.google.com/p/guava-libraries/issues/detail?id=1433

@Shredder121
Copy link
Member

@Shredder121 Shredder121 commented Sep 10, 2014

I understand your concern, and I wish I could sticky this, but a little explanation here:

Querydsl code doesn't use all that much Guava code, so if you use Guava 18.0 it should work, but we compile against 14 because of Batoo JPA.
We are probably going to try to update the dependency soon, but for now we can't as you could see in your pull request, and as I explained in this issue:
#835

I hope this answers your question, and thanks for letting us know!

@SchulteMarkus
Copy link
Author

@SchulteMarkus SchulteMarkus commented Sep 12, 2014

I understand - and this problem is not a big deal, anyhow.

As a workaround for others:

  • Exclude ("exclusions") guava as a querydsl dependency
  • Import guava > 16.0 as an own entry in your pom.xml
@timowest
Copy link
Member

@timowest timowest commented Sep 16, 2014

The next release is a minor release, so dropping official Batoo support in the tests could be considered which would give as the possibility to upgrade Guava. What do you think?

Batoo JPA is not actively maintained anymore and the Guava upgrade pull requests for Batoo have not been accepted.

@Shredder121
Copy link
Member

@Shredder121 Shredder121 commented Sep 16, 2014

In my opinion this is fine by me.

@timowest timowest added this to the 3.5.0 milestone Sep 17, 2014
@SchulteMarkus
Copy link
Author

@SchulteMarkus SchulteMarkus commented Sep 21, 2014

Thanks!

@timowest
Copy link
Member

@timowest timowest commented Sep 30, 2014

Released in 3.5.0

@ratcashdev
Copy link

@ratcashdev ratcashdev commented Jun 1, 2015

How strongly is querydsl (4.0) dependent on Guava? Would it be OK to exclude it completely for a JPA (Eclipselink) & j2EE7 (Glassfish) application?

@Shredder121
Copy link
Member

@Shredder121 Shredder121 commented Jun 2, 2015

We use quite a few features to make up for the Java 6 to 7 bridging(Objects), and for things that should exist in a sane way in the JDK by default (CharMatcher, Sets, Maps).
If you look for Querydsl without Guava I think building it yourself and removing it shouldn't be that much work (?)

@Shredder121
Copy link
Member

@Shredder121 Shredder121 commented Jun 2, 2015

Oh, just remembered, we use the Function interface, so unfortunately I think it requires quite some work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.