Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window argument to electrondisplay #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Nov 29, 2019

This PR adds new signatures electrondisplay(window, [mime,] x) to electrondisplay. It lets you display things in pre-existing Electron.Window.

@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #41 into master will increase coverage by 0.61%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   82.14%   82.75%   +0.61%     
==========================================
  Files           2        2              
  Lines         112      116       +4     
==========================================
+ Hits           92       96       +4     
  Misses         20       20
Impacted Files Coverage Δ
src/ElectronDisplay.jl 78.26% <90%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc52bfb...0f62884. Read the comment docs.

@davidanthoff davidanthoff self-requested a review November 29, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants