WIP: Port to Nulls #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=======================================
Coverage 25.36% 25.36%
=======================================
Files 14 14
Lines 347 347
=======================================
Hits 88 88
Misses 259 259
Continue to review full report at Codecov.
|
nalimilan
reviewed
Oct 6, 2017
| @@ -3,7 +3,7 @@ function _count(source::Enumerable, filter::Function, state) | |||
| while !done(source, state) | |||
| ret_val = next(source, state) | |||
| state = ret_val[2] | |||
| if filter(ret_val[1]) | |||
| if Nulls.coalesce(filter(ret_val[1]), false) | |||
There was a problem hiding this comment.
=== true is simpler and possibly more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to Query.
Not a lot of changes needed here, just the
default_if_emptyupdate and a few cases boolean checks where we want to make sure we account for Nulls behavior ofnull == true = null. This should allow preserving existing semantics in Query/QueryOperators as they worked w/ DataValues.