This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Add includeMoments (default NO) to show Moments as the first album #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #125, I added the property includeMoments to show Moments as the first album.
My implementation is by merging the assets of multiple moments collections (yes, the fetch will be multiple collections), and then add them as a transient collection. This might not be the best way, but it is not slow either. Tested with 1000+ (photos and videos), and it still runs within a second.
If someone knows how to fetch all moments in 1 collection easily, please help.
Note: I added "Moments" to the string files, but without localising them.