Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): filter order execution could have been incorrect #1025

Merged
merged 10 commits into from
May 21, 2021

Conversation

bluestreak01
Copy link
Member

Closes #969

@ideoma
Copy link
Collaborator

ideoma commented May 21, 2021

LGTM

@ideoma
Copy link
Collaborator

ideoma commented May 21, 2021

[PR Coverage check]

😍 pass : 33 / 33 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/model/QueryModel.java 2 2 100.00%
🔵 io/questdb/griffin/SqlOptimiser.java 29 29 100.00%
🔵 io/questdb/griffin/model/ExpressionNode.java 2 2 100.00%

@bluestreak01 bluestreak01 merged commit 3cb01d4 into master May 21, 2021
@bluestreak01 bluestreak01 deleted the fix_sql_filter_analysis branch May 21, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect LEFT OUTER JOIN results
2 participants