Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): fixed isnan() function for SSE2/SSE4 platforms #1044

Merged
merged 6 commits into from
May 21, 2021
Merged

Conversation

bluestreak01
Copy link
Member

closes #1012

Copy link
Contributor

@eugenels eugenels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will not be superfluous to add a comment to CMakeList.txt that we are relying on the /fp:precise mode property: x != x evaluates to true if x is NaN

@@ -1,17213 +1,8 @@
{
"name": "questdb-console",
"version": "0.0.1",
"lockfileVersion": 2,
"lockfileVersion": 1,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change is here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no idea, this file has a life of its own - i ran mvn package and here we are

@ideoma ideoma self-requested a review May 21, 2021 12:24
@ideoma ideoma merged commit 29970cc into master May 21, 2021
@bluestreak01 bluestreak01 deleted the fix_sse2 branch May 21, 2021 13:03
argshook pushed a commit to questdb/ui that referenced this pull request Jun 8, 2022
…stdb#1044)

* fix(sql): fixed isnan() function for SSE2/SSE4 platforms

* chore: linux binary

* chore: OSX amd64 binary

* chore: OSX apple silicon binary

* chore(lib): Compile freebsd lib

* chore: added Eugene to the CODEOWNERS

Co-authored-by: Patrick Mackinlay <github.9fadd@nospam.spacesurfer.com>
argshook pushed a commit to questdb/ui that referenced this pull request Jun 9, 2022
…stdb#1044)

* fix(sql): fixed isnan() function for SSE2/SSE4 platforms

* chore: linux binary

* chore: OSX amd64 binary

* chore: OSX apple silicon binary

* chore(lib): Compile freebsd lib

* chore: added Eugene to the CODEOWNERS

Co-authored-by: Patrick Mackinlay <github.9fadd@nospam.spacesurfer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash: EXCEPTION_ILLEGAL_INSTRUCTION
4 participants