Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql): bitwise ops implementation #1046

Merged
merged 1 commit into from
May 23, 2021
Merged

feat(sql): bitwise ops implementation #1046

merged 1 commit into from
May 23, 2021

Conversation

bluestreak01
Copy link
Member

closes: #1034

@ideoma
Copy link
Collaborator

ideoma commented May 22, 2021

[PR Coverage check]

😍 pass : 26 / 26 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/functions/math/BitwiseNotLongFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/math/BitwiseAndLongFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/math/PowDoubleFunctionFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/math/BitwiseNotIntFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/math/BitwiseXorIntFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/ExpressionParser.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/math/BitwiseOrIntFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/math/BitwiseOrLongFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/math/BitwiseAndIntFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/math/BitwiseXorLongFunctionFactory.java 3 3 100.00%

ideoma
ideoma approved these changes May 23, 2021
View reviewed changes
Copy link
Collaborator

@ideoma ideoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluestreak01 bluestreak01 merged commit 6767dfe into master May 23, 2021
@bluestreak01 bluestreak01 deleted the bitwise_ops branch May 23, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideoma ideoma ideoma approved these changes

@bsmth bsmth Awaiting requested review from bsmth

@eugenels eugenels Awaiting requested review from eugenels

@patrickSpaceSurfer patrickSpaceSurfer Awaiting requested review from patrickSpaceSurfer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bit math
2 participants
@bluestreak01 @ideoma