feat(sql): implementation of 'distinct' algorithm for time series data #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluestreak01
requested review from
bsmth,
eugenels,
ideoma and
patrickSpaceSurfer
as code owners
[PR Coverage check]😍 pass : 18 / 18 (100.00%) file detail
|
ideoma
reviewed
May 24, 2021
| compiler, | ||
| sqlExecutionContext, | ||
| "y", | ||
| "select distinct * from x", |
There was a problem hiding this comment.
How about
select distinct * from x order by ts DESC
There was a problem hiding this comment.
this should work too, in this scenario order by ts desc will be discarded (table is already ordered) and distinct will work as expected, but i will add a test
|
|
||
| @Override | ||
| public void recordAt(Record record, long atRowId) { | ||
| baseCursor.recordAt(record, atRowId); |
There was a problem hiding this comment.
I don't think this is correct, records from this cursor don't map 1 to 1 to base cursor
There was a problem hiding this comment.
this is tested to be correct :)
ideoma
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.