Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql): unary '-' (negation) implementation for all numeric types #1070

Merged
merged 2 commits into from
May 30, 2021
Merged

feat(sql): unary '-' (negation) implementation for all numeric types #1070

merged 2 commits into from
May 30, 2021

Conversation

bluestreak01
Copy link
Member

closes #1065

@ideoma
Copy link
Collaborator

ideoma commented May 29, 2021

[PR Coverage check]

😍 pass : 38 / 38 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/functions/math/NegLongFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/math/NegShortFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/math/NegFloatFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/math/NegIntFunctionFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/catalogue/TypeOfFunctionFactory.java 25 25 100.00%
🔵 io/questdb/griffin/engine/functions/math/NegByteFunctionFactory.java 3 3 100.00%

@bluestreak01 bluestreak01 merged commit c28a350 into master May 30, 2021
@bluestreak01 bluestreak01 deleted the neg_func branch May 30, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideoma ideoma ideoma approved these changes

@bsmth bsmth Awaiting requested review from bsmth

@eugenels eugenels Awaiting requested review from eugenels

@patrickSpaceSurfer patrickSpaceSurfer Awaiting requested review from patrickSpaceSurfer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-500L parsed as Double but should be Long
2 participants
@bluestreak01 @ideoma