http: add parameters commitLag and maxUncommittedRows to /imp #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marregui
force-pushed
the
ma/issue-1181-http-additional-params
branch
2 times, most recently
from
e1f365c
to
d620dd4
Compare
marregui
requested review from
bluestreak01,
bsmth,
eugenels and
rstreics
as code owners
ideoma
reviewed
Jul 21, 2021
core/src/main/java/io/questdb/cutlass/http/processors/TextImportProcessor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/cutlass/http/processors/TextImportProcessor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/cutlass/text/CairoTextWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/cutlass/text/CairoTextWriter.java
Outdated
Show resolved
Hide resolved
…ts (overwrite acts as expected, whacking previous settings)
…eed to be rewritten due to O3
…fferent form system dependent
…erwise NOSYNC. add tests
marregui
force-pushed
the
ma/issue-1181-http-additional-params
branch
from
5eed1f6
to
20bb1ff
Compare
[PR Coverage check]😍 pass : 48 / 48 (100.00%) file detail
|
ideoma
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came as a side effect of #1181.
The solution to that issue was to partition by DAY, or to buy more ram.
Having more control over these two parameters is nice to have.