chore(cairo): virtual memory refactoring #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bluestreak01
commented
Jul 20, 2021
bluestreak01
commented
- new contiguous read-write memory class
- bitmap index writer uses contiguous memory
bluestreak01
requested review from
bsmth,
eugenels,
ideoma and
rstreics
as code owners
ideoma
previously approved these changes
Jul 22, 2021
core/src/main/java/io/questdb/cairo/vm/ContiguousMappedReadOnlyMemory.java
Outdated
Show resolved
Hide resolved
…ve dirty pages under any circumstances
…, fixed size bug in ContinuousVirtualMemory
refactored cache key
…oncrete implementations
…ng) file handles intermittently
ideoma
previously approved these changes
Jul 27, 2021
There was a problem hiding this comment.
I'd name interfaced / clases in reverse patter:
MemoryXYZ
also ReadMemory, WriteMemory to reduce to R
MemoryR, MemoryW
This way when you type Memory| you're autosuggested all R,W,A,C,P,M combinations
Also I'd move creation of this to single factory class to have single interface creating memories, say
class Memory {
static MemorRWC createRWC() {...}
...
}
and put the description of what is the meaning of R,W,..C letter in the Memory class comments.
All this is minor, nice to have imho things
[PR Coverage check]😍 pass : 1202 / 1323 (90.85%) file detail
|
ideoma
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.