Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): push timestamp required on asof join on both sides #1225

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix(sql): push timestamp required on asof join on both sides #1225

merged 1 commit into from
Jul 28, 2021

Conversation

ideoma
Copy link
Collaborator

@ideoma ideoma commented Jul 27, 2021

No description provided.

@ideoma
Copy link
Collaborator Author

ideoma commented Jul 27, 2021

[PR Coverage check]

😍 pass : 14 / 14 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/SqlCodeGenerator.java 14 14 100.00%

@bluestreak01 bluestreak01 merged commit 6299532 into master Jul 28, 2021
@bluestreak01 bluestreak01 deleted the push-ts-requirement-asof-join branch July 28, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

@bsmth bsmth Awaiting requested review from bsmth

@eugenels eugenels Awaiting requested review from eugenels

@rstreics rstreics Awaiting requested review from rstreics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ideoma @bluestreak01