Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ilp): add ingest support for type geohash, when schema exists #1251

Merged
merged 38 commits into from
Aug 31, 2021
Merged

feat(ilp): add ingest support for type geohash, when schema exists #1251

merged 38 commits into from
Aug 31, 2021

Conversation

marregui
Copy link
Contributor

No description provided.

@marregui marregui self-assigned this Aug 11, 2021
@marregui marregui added this to In progress in InfluxDB Line Protocol via automation Aug 11, 2021
@marregui marregui marked this pull request as ready for review August 12, 2021 10:22
@marregui marregui force-pushed the ma/geohash_ilp branch 2 times, most recently from a484c66 to 01c1dff Compare August 17, 2021 19:30
@marregui marregui requested a review from ideoma August 18, 2021 08:18
ideoma
ideoma previously requested changes Aug 21, 2021
View reviewed changes
core/src/main/java/io/questdb/cairo/GeoHashes.java Outdated Show resolved Hide resolved
core/src/main/java/io/questdb/cutlass/line/CairoLineProtoParserSupport.java Outdated Show resolved Hide resolved
core/src/main/java/io/questdb/cutlass/line/tcp/LineTcpMeasurementScheduler.java Outdated Show resolved Hide resolved
core/src/main/java/io/questdb/cutlass/line/tcp/LineTcpMeasurementScheduler.java Outdated Show resolved Hide resolved
core/src/main/java/io/questdb/cutlass/line/udp/CairoLineProtoParser.java Outdated Show resolved Hide resolved
core/src/test/java/io/questdb/cutlass/line/tcp/LineTcpConnectionContextTest.java Outdated Show resolved Hide resolved
core/src/main/java/io/questdb/cutlass/line/tcp/LineTcpMeasurementScheduler.java Outdated Show resolved Hide resolved
core/src/main/java/io/questdb/cutlass/line/tcp/LineTcpMeasurementScheduler.java Outdated Show resolved Hide resolved
@marregui marregui requested a review from ideoma August 24, 2021 10:45
@marregui
Copy link
Contributor Author

heck yeah!

@marregui
Copy link
Contributor Author

@ideoma you were right, geohashes with len > 12 are now truncated to appropriate size

@ideoma
Copy link
Collaborator

ideoma commented Aug 31, 2021

[PR Coverage check]

😍 pass : 121 / 130 (93.08%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/ColumnType.java 0 1 00.00%
🔵 io/questdb/cairo/TableWriter.java 4 10 40.00%
🔵 io/questdb/griffin/engine/functions/rnd/RndGeoHashFunctionFactory.java 3 5 60.00%
🔵 io/questdb/cutlass/line/CairoLineProtoParserSupport.java 41 41 100.00%
🔵 io/questdb/griffin/engine/functions/cast/CastStrToGeoHashFunctionFactory.java 1 1 100.00%
🔵 io/questdb/cutlass/line/tcp/LineTcpMeasurementScheduler.java 4 4 100.00%
🔵 io/questdb/cutlass/line/udp/CairoLineProtoParser.java 25 25 100.00%
🔵 io/questdb/std/Rnd.java 4 4 100.00%
🔵 io/questdb/cutlass/line/tcp/NewLineProtoParser.java 3 3 100.00%
🔵 io/questdb/cairo/GeoHashes.java 36 36 100.00%

@bluestreak01 bluestreak01 merged commit 210e7e4 into master Aug 31, 2021
InfluxDB Line Protocol automation moved this from In progress to Done Aug 31, 2021
@bluestreak01 bluestreak01 deleted the ma/geohash_ilp branch August 31, 2021 13:50
rstreics pushed a commit that referenced this pull request Sep 3, 2021
@marregui @rstreics
feat(ilp): add ingest support for type geohash, when schema exists (#…
84f0009 
…1251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

@bsmth bsmth Awaiting requested review from bsmth

@eugenels eugenels Awaiting requested review from eugenels

@rstreics rstreics Awaiting requested review from rstreics

@ideoma ideoma Awaiting requested review from ideoma

Assignees

@marregui marregui

Labels
None yet
Projects
No open projects
InfluxDB Line Protocol
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marregui @ideoma @bluestreak01