Add make_geohash function #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenels
requested review from
bluestreak01,
bsmth,
ideoma and
rstreics
as code owners
marregui
previously requested changes
Aug 25, 2021
bluestreak01
requested changes
Aug 27, 2021
.../java/io/questdb/griffin/engine/functions/geohash/GeoHashFromCoordinatesFunctionFactory.java
Show resolved
Hide resolved
.../java/io/questdb/griffin/engine/functions/geohash/GeoHashFromCoordinatesFunctionFactory.java
Outdated
Show resolved
Hide resolved
.../java/io/questdb/griffin/engine/functions/geohash/GeoHashFromCoordinatesFunctionFactory.java
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/rnd/RndGeoHashFunctionFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/rnd/RndGeoHashFunctionFactory.java
Outdated
Show resolved
Hide resolved
marregui
reviewed
Aug 30, 2021
.../java/io/questdb/griffin/engine/functions/geohash/GeoHashFromCoordinatesFunctionFactory.java
Show resolved
Hide resolved
eugenels
force-pushed
the
gh_from_coord
branch
from
07f14d7
to
752ad1f
Compare
make_geohash(lon, lat, bits)
…geohash functions
eugenels
force-pushed
the
gh_from_coord
branch
from
30af217
to
b7876bf
Compare
ideoma
reviewed
Sep 3, 2021
.../java/io/questdb/griffin/engine/functions/geohash/GeoHashFromCoordinatesFunctionFactory.java
Show resolved
Hide resolved
[PR Coverage check]😍 pass : 27 / 28 (96.43%) file detail
|
bluestreak01
approved these changes
Sep 6, 2021
bluestreak01
dismissed
marregui’s stale review
need to expedite the PR, can optimise later
marregui
pushed a commit
that referenced
this pull request
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_geohash(lon, lat, bits)