Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geohash support for PGWire protocol #1270

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Add geohash support for PGWire protocol #1270

merged 4 commits into from
Sep 3, 2021

Conversation

eugenels
Copy link
Contributor

No description provided.

@marregui
Copy link
Contributor

LGTM

I would add a few more tests though, around the areas of:

  • geohashes containing wrong characters e.g. '@'
  • table column declared with a precision, then the insert containing a LOWER precision geohash -> should reject
  • table column declared with a precision, then the insert containing a HIGHER precision geohash -> should truncate
  • something that looks like a geohash but it is not, e.g. londer than 60 bits or 12 chars

marregui
marregui previously approved these changes Aug 25, 2021
Copy link
Contributor

@marregui marregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Personal opinion, I would merge and then add the missing todo part as a different task.
There is a PR in transit at the moment that could be merged and which contains literal syntax for geohash constants.

@bluestreak01 bluestreak01 marked this pull request as ready for review August 30, 2021 09:56
@ideoma
Copy link
Collaborator

ideoma commented Sep 3, 2021

[PR Coverage check]

😍 pass : 46 / 47 (97.87%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/pgwire/PGConnectionContext.java 45 46 97.83%
🔵 io/questdb/cutlass/pgwire/PGOids.java 1 1 100.00%

@bluestreak01 bluestreak01 merged commit f752732 into master Sep 3, 2021
@bluestreak01 bluestreak01 deleted the pghash branch September 3, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants