Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw invalid date exception on negative time interval #1277

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Throw invalid date exception on negative time interval #1277

merged 4 commits into from
Sep 2, 2021

Conversation

eugenels
Copy link
Contributor

No description provided.

@eugenels eugenels mentioned this pull request Aug 30, 2021
Closed
@ideoma
Copy link
Collaborator

ideoma commented Sep 2, 2021

[PR Coverage check]

😍 pass : 7 / 8 (87.50%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/model/IntervalUtils.java 7 8 87.50%

@bluestreak01 bluestreak01 merged commit fa9284c into master Sep 2, 2021
@bluestreak01 bluestreak01 deleted the neg-period branch September 2, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

@bsmth bsmth Awaiting requested review from bsmth

@ideoma ideoma Awaiting requested review from ideoma

@rstreics rstreics Awaiting requested review from rstreics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eugenels @ideoma @bluestreak01