Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ilp): fixed missing index update when ingesting data over ILP #1302

Merged
merged 5 commits into from
Sep 10, 2021
Merged

fix(ilp): fixed missing index update when ingesting data over ILP #1302

merged 5 commits into from
Sep 10, 2021

Conversation

bluestreak01
Copy link
Member

Closes #1278

ideoma
ideoma previously approved these changes Sep 10, 2021
View reviewed changes
@ideoma
Copy link
Collaborator

ideoma commented Sep 10, 2021

[PR Coverage check]

😍 pass : 27 / 31 (87.10%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/http/HttpConnectionContext.java 12 16 75.00%
🔵 io/questdb/cairo/TableWriter.java 4 4 100.00%
🔵 io/questdb/network/AbstractIODispatcher.java 1 1 100.00%
🔵 io/questdb/std/ObjList.java 10 10 100.00%

marregui
marregui approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@marregui marregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluestreak01 bluestreak01 merged commit 6fce0f2 into master Sep 10, 2021
@bluestreak01 bluestreak01 deleted the fix_index_update branch September 10, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marregui marregui marregui approved these changes

@ideoma ideoma ideoma left review comments

@bsmth bsmth Awaiting requested review from bsmth

@eugenels eugenels Awaiting requested review from eugenels

@mariusgheorghies mariusgheorghies Awaiting requested review from mariusgheorghies

@rstreics rstreics Awaiting requested review from rstreics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent filtering on indexed SYMBOL columns when ILP modifies table schema
3 participants
@bluestreak01 @ideoma @marregui