feat(sql): implement "touch" function, useful to preload the data from disk into system page cache. #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenels
requested review from
bluestreak01,
bsmth,
ideoma,
mariusgheorghies,
marregui and
rstreics
as code owners
ideoma
requested changes
Sep 10, 2021
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Outdated
Show resolved
Hide resolved
bluestreak01
requested changes
Sep 10, 2021
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Outdated
Show resolved
Hide resolved
ideoma
reviewed
Sep 10, 2021
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Outdated
Show resolved
Hide resolved
eugenels
changed the title
eugenels
changed the title
ideoma
reviewed
Sep 10, 2021
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Outdated
Show resolved
Hide resolved
bluestreak01
requested changes
Sep 11, 2021
core/src/test/java/io/questdb/griffin/engine/functions/TouchTableFunctionTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Show resolved
Hide resolved
marregui
reviewed
Sep 13, 2021
core/src/main/java/io/questdb/griffin/engine/functions/table/TouchTableFunctionFactory.java
Show resolved
Hide resolved
bluestreak01
approved these changes
Sep 13, 2021
|
Do we need any documantation for this feature? |
[PR Coverage check]😍 pass : 10 / 10 (100.00%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.